Use chrome app favicons in the ChromeOS shelf app window list.

Use chrome app favicons in the ChromeOS shelf app window list.

This CL allows apps to customize their appearance in the per-app window list
in the Ash shelf by changing their favicon. Each app window will use the 
favicon if it exists, falling back to the current behavior of a downscaled
app icon if it doesn't.

BUG=390907
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285516

[stevenjb, 2014-07-24 18:52:51]

I believe that this may break Hangouts since they use a separate favicon for the
window frame from the shelf icon (although I could be mistaken).

[stevenjb, 2014-07-24 18:53:06]

+ flackr@

[calamity, 2014-07-24 23:41:15]

On 2014/07/24 18:52:51, stevenjb wrote:
> I believe that this may break Hangouts since they use a separate favicon for
the
> window frame from the shelf icon (although I could be mistaken).

Oops, sorry, I was a bit unclear. This is for the icons in the application list
when you have more than one window open for an app. The intended use case is to
make the favicon different from the app icon to distinguish between different
windows.

[stevenjb, 2014-07-25 00:40:10]

On 2014/07/24 23:41:15, calamity wrote:
> On 2014/07/24 18:52:51, stevenjb wrote:
> > I believe that this may break Hangouts since they use a separate favicon for
> the
> > window frame from the shelf icon (although I could be mistaken).
> 
> Oops, sorry, I was a bit unclear. This is for the icons in the application
list
> when you have more than one window open for an app. The intended use case is
to
> make the favicon different from the app icon to distinguish between different
> windows.

Sorry, my bad, I didn't look closely enough at the function being changed, it's
been a little while. Since this is in a list, I can't think of a case where
someone would set a favicon but want to use the window app icon instead.

lgtm

[calamity, 2014-07-25 03:24:48]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-07-25 03:26:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/calamity@chromium.org/411543009/1

[commit-bot: I haz the power, 2014-07-25 07:13:01]

Change committed as 285516