Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 411543006: Explicit container priority (Closed)

Created:
6 years, 5 months ago by oshima
Modified:
6 years, 5 months ago
Reviewers:
sadrul
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Explicit container priority * This will allow a client to create & destroy a container with specific z order, without relying on the order it is created. (will be used for login/lock screen) * Changed to single click to open home card, instead of double click because it's easier and consistent with ash. (ash uses single click to open/activate things) * I tried to add check but I couldn't come up with good solution using window oberver as the child is always added to the top first. BUG=394121 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285185

Patch Set 1 : #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -25 lines) Patch
M athena/athena.gyp View 1 2 3 5 2 chunks +2 lines, -1 line 0 comments Download
A athena/common/container_priorities.h View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M athena/home/home_card_impl.cc View 1 2 3 5 2 chunks +2 lines, -1 line 0 comments Download
M athena/home/minimized_home.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/main/debug/debug_window.cc View 2 chunks +3 lines, -1 line 0 comments Download
M athena/screen/public/screen_manager.h View 1 chunk +4 lines, -1 line 0 comments Download
M athena/screen/screen_manager_impl.cc View 1 2 3 4 4 chunks +62 lines, -18 lines 0 comments Download
A athena/screen/screen_manager_unittest.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M athena/virtual_keyboard/virtual_keyboard_manager_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M athena/wm/window_manager_impl.cc View 1 2 3 5 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
oshima
6 years, 5 months ago (2014-07-23 06:43:38 UTC) #1
sadrul
Do you have the right CL up?
6 years, 5 months ago (2014-07-23 17:00:13 UTC) #2
oshima
On 2014/07/23 17:00:13, sadrul wrote: > Do you have the right CL up? oops, sorry. ...
6 years, 5 months ago (2014-07-23 17:17:10 UTC) #3
sadrul
LGTM https://codereview.chromium.org/411543006/diff/90001/athena/common/container_priorities.h File athena/common/container_priorities.h (right): https://codereview.chromium.org/411543006/diff/90001/athena/common/container_priorities.h#newcode15 athena/common/container_priorities.h:15: CP_DEBUG = 4, Do you want to number ...
6 years, 5 months ago (2014-07-23 18:37:24 UTC) #4
oshima
https://codereview.chromium.org/411543006/diff/90001/athena/common/container_priorities.h File athena/common/container_priorities.h (right): https://codereview.chromium.org/411543006/diff/90001/athena/common/container_priorities.h#newcode15 athena/common/container_priorities.h:15: CP_DEBUG = 4, On 2014/07/23 18:37:24, sadrul wrote: > ...
6 years, 5 months ago (2014-07-23 20:51:39 UTC) #5
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 5 months ago (2014-07-23 20:52:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/411543006/130001
6 years, 5 months ago (2014-07-23 20:54:25 UTC) #7
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 5 months ago (2014-07-23 22:40:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/411543006/170001
6 years, 5 months ago (2014-07-23 22:43:24 UTC) #9
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 5 months ago (2014-07-24 00:19:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/411543006/190001
6 years, 5 months ago (2014-07-24 00:21:45 UTC) #11
oshima
The CQ bit was unchecked by oshima@chromium.org
6 years, 5 months ago (2014-07-24 04:47:18 UTC) #12
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 5 months ago (2014-07-24 04:47:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/411543006/190001
6 years, 5 months ago (2014-07-24 04:49:16 UTC) #14
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 5 months ago (2014-07-24 06:01:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/411543006/210001
6 years, 5 months ago (2014-07-24 06:01:46 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 07:58:53 UTC) #17
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 11:09:17 UTC) #18
Message was sent while issue was closed.
Change committed as 285185

Powered by Google App Engine
This is Rietveld 408576698