Issue 411543005: Encode all grit outputs in .gn files

Issue 411543005: Encode all grit outputs in .gn files (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, sadrul, jam, darin-cc_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Encode all grit outputs in .gn files This finishes the rest of the Grit outputs that was started in a previous pass, and removes the ability to optionally deduce outputs at GN-time (which is slow so we don't want to do it). R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284947

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : git log #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+911 lines, -331 lines)			Patch
M	ash/resources/BUILD.gn	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	ash/strings/BUILD.gn	View		1 chunk	+57 lines, -0 lines	0 comments	Download
M	build/config/android/rules.gni	View	1 2 3 4 5	3 chunks	+9 lines, -1 line	0 comments	Download
D	build/secondary/chrome/BUILD.gn	View		1 chunk	+0 lines, -299 lines	0 comments	Download
M	build/secondary/tools/grit/grit_rule.gni	View	1 2 3	3 chunks	+23 lines, -31 lines	0 comments	Download
M	chrome/app/BUILD.gn	View		2 chunks	+171 lines, -0 lines	0 comments	Download
M	chrome/app/resources/BUILD.gn	View		2 chunks	+115 lines, -0 lines	0 comments	Download
M	chrome/app/theme/BUILD.gn	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/common/BUILD.gn	View	1 2 3	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/renderer/BUILD.gn	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	components/resources/BUILD.gn	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	components/strings/BUILD.gn	View		1 chunk	+57 lines, -0 lines	0 comments	Download
M	content/BUILD.gn	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	device/bluetooth/BUILD.gn	View		1 chunk	+57 lines, -0 lines	0 comments	Download
M	extensions/BUILD.gn	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	extensions/strings/BUILD.gn	View		1 chunk	+57 lines, -0 lines	0 comments	Download
M	net/BUILD.gn	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	third_party/libaddressinput/BUILD.gn	View		1 chunk	+58 lines, -0 lines	0 comments	Download
M	ui/android/BUILD.gn	View		1 chunk	+46 lines, -0 lines	0 comments	Download
M	ui/keyboard/BUILD.gn	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	ui/resources/BUILD.gn	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	ui/strings/BUILD.gn	View		1 chunk	+114 lines, -0 lines	0 comments	Download
M	webkit/BUILD.gn	View		1 chunk	+68 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

Rubberstamp LGTM. https://codereview.chromium.org/411543005/diff/40001/third_party/libaddressinput/BUILD.gn File third_party/libaddressinput/BUILD.gn (right): https://codereview.chromium.org/411543005/diff/40001/third_party/libaddressinput/BUILD.gn#newcode37 third_party/libaddressinput/BUILD.gn:37: "messages.h", I've failed to figure out what ...

6 years, 5 months ago (2014-07-22 21:10:46 UTC) #2

brettw

https://codereview.chromium.org/411543005/diff/40001/third_party/libaddressinput/BUILD.gn File third_party/libaddressinput/BUILD.gn (right): https://codereview.chromium.org/411543005/diff/40001/third_party/libaddressinput/BUILD.gn#newcode37 third_party/libaddressinput/BUILD.gn:37: "messages.h", On 2014/07/22 21:10:45, viettrungluu wrote: > I've failed ...

6 years, 5 months ago (2014-07-22 23:14:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #6 manually as r284947.

Expand Messages | Collapse Messages