Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 411543004: Use OnSuccess() with no arguments in MockScreenOrientationClient (Closed)

Created:
6 years, 5 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 5 months ago
Reviewers:
abarth-chromium
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use OnSuccess() with no arguments in MockScreenOrientationClient BUG=162827 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284901

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M content/shell/renderer/test_runner/mock_screen_orientation_client.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mlamouri (slow - plz ping)
Forgot that one :(
6 years, 5 months ago (2014-07-22 16:57:32 UTC) #1
abarth-chromium
LGTM
6 years, 5 months ago (2014-07-22 19:24:12 UTC) #2
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 5 months ago (2014-07-23 09:07:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/411543004/1
6 years, 5 months ago (2014-07-23 09:08:09 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 11:12:30 UTC) #5
Message was sent while issue was closed. 
Change committed as 284901

Powered by Google App Engine
This is Rietveld 408576698