Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 411523005: Revert of Clean up. Experimental user avatars removed. (Closed)

Created:
6 years, 5 months ago by johnme
Modified:
6 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Clean up. Experimental user avatars removed. (https://codereview.chromium.org/395133002/) Reason for revert: This broke build: http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/419 With error: /mnt/data/b/build/slave/Linux_ChromiumOS_Tests__dbg__2_/build/src/out/Debug/app_shell_browsertests: symbol lookup error: /mnt/data/b/build/slave/Linux_ChromiumOS_Tests__dbg__2_/build/src/out/Debug/lib/libmedia.so: undefined symbol: Ebml_Serialize Original issue's description: > Clean up. Experimental user avatars removed. > > BUG=387738 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284666 TBR=scherkus@chromium.org,nkostylev@chromium.org,merkulova@chromium.org NOTREECHECKS=true NOTRY=true BUG=387738 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284676

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+655 lines, -9 lines) Patch
M chrome/browser/chromeos/login/users/user.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/user_images_grid.js View 3 chunks +56 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/user_image_source.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/user_image_source.cc View 3 chunks +36 lines, -5 lines 0 comments Download
M components/user_manager/user_image/user_image.h View 4 chunks +11 lines, -1 line 0 comments Download
M components/user_manager/user_image/user_image.cc View 3 chunks +25 lines, -2 lines 0 comments Download
M media/BUILD.gn View 1 chunk +21 lines, -0 lines 0 comments Download
A media/formats/webm/chromeos/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A media/formats/webm/chromeos/ebml_writer.h View 1 chunk +21 lines, -0 lines 0 comments Download
A media/formats/webm/chromeos/ebml_writer.cc View 1 chunk +33 lines, -0 lines 0 comments Download
A media/formats/webm/chromeos/webm_encoder.h View 1 chunk +106 lines, -0 lines 0 comments Download
A media/formats/webm/chromeos/webm_encoder.cc View 1 chunk +321 lines, -0 lines 0 comments Download
M media/media.gyp View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
johnme
Created Revert of Clean up. Experimental user avatars removed.
6 years, 5 months ago (2014-07-22 14:41:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johnme@chromium.org/411523005/1
6 years, 5 months ago (2014-07-22 14:42:57 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 14:44:31 UTC) #3
Message was sent while issue was closed. 
Change committed as 284676

Powered by Google App Engine
This is Rietveld 408576698