Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: chrome/browser/download/download_permission_request.cc

Issue 411503005: Change tests to prepare for turning on the permission bubble flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_permission_request.cc
diff --git a/chrome/browser/download/download_permission_request.cc b/chrome/browser/download/download_permission_request.cc
index 18e19959337d86d03d0a7b0f729395e642298789..552a7e149d228bea854a96458e39320a4692365f 100644
--- a/chrome/browser/download/download_permission_request.cc
+++ b/chrome/browser/download/download_permission_request.cc
@@ -29,8 +29,10 @@ base::string16 DownloadPermissionRequest::GetMessageTextFragment() const {
bool DownloadPermissionRequest::HasUserGesture() const {
// TODO(gbillock): user gesture for multiple downloads is difficult to
- // propagate, and the normal thing is that it is background.
- return false;
+ // propagate, and the normal thing is that it is background. So lie to
+ // the manager and say it is user gestured. This needs to be examined
+ // for policy coherence...
+ return true;
}
GURL DownloadPermissionRequest::GetRequestingHostname() const {

Powered by Google App Engine
This is Rietveld 408576698