Noop gear button in VK menu popup if not logged in

Noop gear button in VK menu popup if not logged in

BUG=395621
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286320

[Shu Chen, 2014-07-23 02:50:58]

lgtm

[Shu Chen, 2014-07-23 02:57:39]

https://codereview.chromium.org/411463007/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/api/input/input.cc (right):

https://codereview.chromium.org/411463007/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/input/input.cc:178: return true;
nits: avoid getting lock state when user is not logged in.

[bshe, 2014-07-23 02:59:49]

https://codereview.chromium.org/411463007/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/api/input/input.cc (right):

https://codereview.chromium.org/411463007/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/input/input.cc:178: return true;
On 2014/07/23 02:57:39, Shu Chen wrote:
> nits: avoid getting lock state when user is not logged in.

Done.

[Shu Chen, 2014-07-23 06:25:06]

The CQ bit was checked by shuchen@chromium.org

[Shu Chen, 2014-07-23 06:25:35]

Verified on linux_chromeos, and committing.

[commit-bot: I haz the power, 2014-07-23 06:29:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bshe@chromium.org/411463007/60001

[commit-bot: I haz the power, 2014-07-23 08:27:04]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/36650)

[commit-bot: I haz the power, 2014-07-23 08:29:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 08:29:41]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Shu Chen, 2014-07-23 14:23:19]

https://codereview.chromium.org/411463007/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/api/input/input.cc (right):

https://codereview.chromium.org/411463007/diff/60001/chrome/browser/extension...
chrome/browser/extensions/api/input/input.cc:175: if
(!chromeos::UserManager::Get()->IsUserLoggedIn() ||
I think you need to guard this code block in #ifdef CHROME_OS.

[bshe, 2014-07-24 17:24:16]

https://codereview.chromium.org/411463007/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/api/input/input.cc (right):

https://codereview.chromium.org/411463007/diff/60001/chrome/browser/extension...
chrome/browser/extensions/api/input/input.cc:175: if
(!chromeos::UserManager::Get()->IsUserLoggedIn() ||
On 2014/07/23 14:23:19, Shu Chen wrote:
> I think you need to guard this code block in #ifdef CHROME_OS.

Done.

[bshe, 2014-07-24 17:24:28]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2014-07-24 17:25:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bshe@chromium.org/411463007/80001

[commit-bot: I haz the power, 2014-07-24 21:24:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-24 21:28:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-24 21:28:55]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[bshe, 2014-07-24 21:48:54]

+mek for OWNER

[bshe, 2014-07-29 17:05:20]

On 2014/07/24 21:48:54, bshe wrote:
> +mek for OWNER

friendly ping?

[Marijn Kruisselbrink, 2014-07-29 17:21:57]

I'm sorry for the delay, I somehow overlooked this. LGTM

[bshe, 2014-07-29 17:33:37]

On 2014/07/29 17:21:57, Marijn Kruisselbrink wrote:
> I'm sorry for the delay, I somehow overlooked this. LGTM

No problem. Thanks for review! cqing..

[bshe, 2014-07-29 17:33:41]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2014-07-29 17:35:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bshe@chromium.org/411463007/120001

[commit-bot: I haz the power, 2014-07-29 22:37:49]

Change committed as 286320