Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 411463005: hid: Linux expects the report ID in the output report buffer. (Closed)

Created:
6 years, 5 months ago by Reilly Grant (use Gerrit)
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

hid: Linux expects the report ID in the output report buffer. The Linux hidraw interface expects the buffer written to the device to always have the report ID as the first byte. Remove the conditional that only added this data when the report ID was non-zero. BUG= R=rockot@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285041

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M device/hid/hid_connection_linux.cc View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Reilly Grant (use Gerrit)
6 years, 5 months ago (2014-07-23 00:17:05 UTC) #1
Ken Rockot(use gerrit already)
lgtm
6 years, 5 months ago (2014-07-23 13:25:25 UTC) #2
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 5 months ago (2014-07-23 16:03:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reillyg@chromium.org/411463005/1
6 years, 5 months ago (2014-07-23 16:03:46 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 21:15:03 UTC) #5
Message was sent while issue was closed.
Change committed as 285041

Powered by Google App Engine
This is Rietveld 408576698