[Sync] Trigger refresh for synced notifications on context change

[Sync] Trigger refresh for synced notifications on context change

If the context change is of type REFRESH_NEEDED, we post a notification
to refresh the type. This is a temporary workaround until the
GenericChangeProcessor can properly tell the SyncManager that a refresh
is needed.

BUG=396298
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285101

[Nicolas Zea, 2014-07-22 23:07:08]

+Pete, PTAL. Prior to this patch context changes would not force a sync cycle.

[Pete Williamson, 2014-07-23 00:35:44]

On 2014/07/22 23:07:08, Nicolas Zea wrote:
> +Pete, PTAL. Prior to this patch context changes would not force a sync cycle.

I didn't see any calls to the new RefreshRequest method in
chrome_notifier_service.  Should I have?

[Nicolas Zea, 2014-07-23 17:26:57]

The refresh_request_ closure is just a bound NotifyRefreshNeeded callback. Or
were you referring to something else?

[Pete Williamson, 2014-07-23 17:51:34]

On 2014/07/23 17:26:57, Nicolas Zea wrote:
> The refresh_request_ closure is just a bound NotifyRefreshNeeded callback. Or
> were you referring to something else?

I see new code added for the NotifyRefreshNeeded callback.  How does it get
called?  I see it being bound in the constructor, but I didn't see any code that
would cause this to be called when something happened that would require a
refresh.

[Nicolas Zea, 2014-07-23 18:49:00]

On 2014/07/23 17:51:34, Pete Williamson wrote:
> On 2014/07/23 17:26:57, Nicolas Zea wrote:
> > The refresh_request_ closure is just a bound NotifyRefreshNeeded callback.
Or
> > were you referring to something else?
> 
> I see new code added for the NotifyRefreshNeeded callback.  How does it get
> called?  I see it being bound in the constructor, but I didn't see any code
that
> would cause this to be called when something happened that would require a
> refresh.

refresh_request_ is called in line 248 of the shim as part of SetRenderContext,
which is invoked by the JS api code.

[Pete Williamson, 2014-07-23 20:41:47]

lgtm

[Nicolas Zea, 2014-07-23 20:48:11]

The CQ bit was checked by zea@chromium.org

[commit-bot: I haz the power, 2014-07-23 20:51:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zea@chromium.org/411463003/60001

[commit-bot: I haz the power, 2014-07-24 01:05:15]

Change committed as 285101