Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 411453003: Revert of Revert of Update V8 to version 3.28.30 (based on bleeding_edge revision r22489). (Closed)

Created:
6 years, 5 months ago by Michael Achenbach
Modified:
6 years, 5 months ago
CC:
chromium-reviews, Toon Verwaest
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Update V8 to version 3.28.30 (based on bleeding_edge revision r22489). (https://codereview.chromium.org/405313002/) Reason for revert: See https://code.google.com/p/chromium/issues/detail?id=395882 The reason for the test failures in blink has been fixed with the last blink roll. Original issue's description: > Revert of Update V8 to version 3.28.30 (based on bleeding_edge revision r22489). (https://codereview.chromium.org/407733005/) > > Reason for revert: > Seems to be causing xss-DENIED-method-with-iframe-proto.html to time out on multiple bots; see http://crbug.com/395882 . > > Original issue's description: > > Update V8 to version 3.28.30 (based on bleeding_edge revision r22489). > > > > Please reply to the V8 sheriff svenpanne@chromium.org in case of problems. > > > > TBR=svenpanne@chromium.org > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284420 > > TBR=svenpanne@chromium.org,machenbach@chromium.org > NOTREECHECKS=true > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284572 TBR=svenpanne@chromium.org,pkasting@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
Created Revert of Revert of Update V8 to version 3.28.30 (based on bleeding_edge revision r22489).
6 years, 5 months ago (2014-07-22 07:16:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/411453003/1
6 years, 5 months ago (2014-07-22 07:16:51 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 07:18:21 UTC) #3
Message was sent while issue was closed.
Change committed as 284642

Powered by Google App Engine
This is Rietveld 408576698