Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 411423003: Make the default alternate protcol probability threshold 1, not 0. (Closed)

Created:
6 years, 5 months ago by Ryan Hamilton
Modified:
6 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Make the default alternate protcol probability threshold 1, not 0. This means that by default, Chrome will honor headers like: Alternate-Protocol: 80:quic Alternate-Protocol: 80:quic,p=1 But not: Alternate-Protocol: 80:quic,p=.5 Eventually we need to switch to a dynamic threshold, but on step at a time. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285473

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M net/http/http_network_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_server_properties_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ryan Hamilton
6 years, 5 months ago (2014-07-24 17:13:21 UTC) #1
ramant (doing other things)
lgtm
6 years, 5 months ago (2014-07-24 17:25:12 UTC) #2
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 5 months ago (2014-07-24 17:26:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/411423003/1
6 years, 5 months ago (2014-07-24 17:27:47 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 20:38:18 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 21:13:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/2047)
6 years, 5 months ago (2014-07-24 21:13:03 UTC) #7
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 5 months ago (2014-07-25 01:57:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/411423003/1
6 years, 5 months ago (2014-07-25 02:25:55 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 03:57:01 UTC) #10
Message was sent while issue was closed.
Change committed as 285473

Powered by Google App Engine
This is Rietveld 408576698