Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 411393003: IndexedDB: Added MessageLoop to IndexedDBBackingStoreTest (Closed)

Created:
6 years, 5 months ago by cmumford
Modified:
6 years, 5 months ago
Reviewers:
jsbell, Ryan Sleevi
CC:
chromium-reviews, jam, alecflett, darin-cc_chromium.org, dgrogan, jsbell+idb_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Added MessageLoop to IndexedDBBackingStoreTest Tests use //net so a message loop is required. BUG=395358 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285419

Patch Set 1 #

Patch Set 2 : MessageLoop -> TestBrowserThreadBundle #

Patch Set 3 : Removed assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/browser/indexed_db/indexed_db_backing_store_unittest.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
cmumford
6 years, 5 months ago (2014-07-24 16:40:44 UTC) #1
Ryan Sleevi
Does a content::TestBrowserThreadBundle make sense?
6 years, 5 months ago (2014-07-24 16:41:35 UTC) #2
cmumford
On 2014/07/24 16:41:35, Ryan Sleevi wrote: > Does a content::TestBrowserThreadBundle make sense? I think so. ...
6 years, 5 months ago (2014-07-24 16:50:08 UTC) #3
Ryan Sleevi
LGTM, but the assert is probably overkill
6 years, 5 months ago (2014-07-24 16:56:57 UTC) #4
jsbell
lgtm
6 years, 5 months ago (2014-07-24 17:01:27 UTC) #5
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 5 months ago (2014-07-24 17:08:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/411393003/40001
6 years, 5 months ago (2014-07-24 17:10:15 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 20:19:35 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 20:52:46 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/2033)
6 years, 5 months ago (2014-07-24 20:52:47 UTC) #10
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 5 months ago (2014-07-24 22:47:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/411393003/40001
6 years, 5 months ago (2014-07-24 22:48:58 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 00:02:30 UTC) #13
Message was sent while issue was closed. 
Change committed as 285419

Powered by Google App Engine
This is Rietveld 408576698