MediaUrlInterceptor for embedders to handle custom urls.

content/browser/media/android/browser_media_player_manager.h

Index: content/browser/media/android/browser_media_player_manager.h
diff --git a/content/browser/media/android/browser_media_player_manager.h b/content/browser/media/android/browser_media_player_manager.h
index 4c533885bf61234bc0ae90e6549fc256e96d8c1e..5f3fae57565fa377082a5ecc370b690742f62377 100644
--- a/content/browser/media/android/browser_media_player_manager.h
+++ b/content/browser/media/android/browser_media_player_manager.h
@@ -16,6 +16,7 @@
 #include "ipc/ipc_message.h"
 #include "media/base/android/media_player_android.h"
 #include "media/base/android/media_player_manager.h"
+#include "media/base/android/media_url_interceptor.h"
 #include "ui/gfx/rect_f.h"
 #include "url/gurl.h"
 
@@ -44,6 +45,10 @@ class CONTENT_EXPORT BrowserMediaPlayerManager
   typedef BrowserMediaPlayerManager* (*Factory)(RenderFrameHost*);
   static void RegisterFactory(Factory factory);
 
+  // Permits embedders to handle custom urls.
+  static void RegisterMediaUrlInterceptor(

[mnaganov (inactive), 2014/07/25 08:17:49]

I really don't like the idea that the interceptor is static. Although probably
in reality there can be no more than one BrowserMediaPlayerManager instance,
this class is technically not a singleton. Can we set the interceptor an an
instance instead?

[Ignacio Solla, 2014/07/25 10:35:06]

The interceptor is static because it should be shared across all the instances
of BrowserMediaPlayerManager. The binary decides whether to register an
interceptor at start-up time.

I had also tried to make it a field, but that requires providing our  own
BrowserMediaPlayerManager.Factory and AwBrowserMediaPlayerManager just to
register the interceptor, which makes the code obscure and is over-kill IMO. I
prefer the current version because it is simpler and the intent is clearer. 

+      media::MediaUrlInterceptor* media_url_interceptor);
+
   // Returns a new instance using the registered factory if available.
   static BrowserMediaPlayerManager* Create(RenderFrameHost* rfh);
 
@@ -84,6 +89,7 @@ class CONTENT_EXPORT BrowserMediaPlayerManager
   virtual void OnVideoSizeChanged(
       int player_id, int width, int height) OVERRIDE;
   virtual media::MediaResourceGetter* GetMediaResourceGetter() OVERRIDE;
+  virtual media::MediaUrlInterceptor* GetMediaUrlInterceptor() OVERRIDE;
   virtual media::MediaPlayerAndroid* GetFullscreenPlayer() OVERRIDE;
   virtual media::MediaPlayerAndroid* GetPlayer(int player_id) OVERRIDE;
   virtual void RequestFullScreen(int player_id) OVERRIDE;