Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 411293002: re-land: Track history of events in GCTracer. (Closed)

Created:
6 years, 5 months ago by ernstm
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

re-land: Track history of events in GCTracer. - track incremental marking stats directly on GCTracer. - add simple ring buffer class. - track last 10 scavenges and mark-compacts in ring buffers on GCTracer. - various clean-ups. This is a re-land of https://codereview.chromium.org/391413006/ with - int instead of size_t in ring buffer unit test. - git cl format R=hpayer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22593

Patch Set 1 #

Patch Set 2 : Add missing cast to int. #

Patch Set 3 : Disable failing SerializeToplevelIsolates test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+479 lines, -213 lines) Patch
M src/heap.h View 5 chunks +166 lines, -52 lines 0 comments Download
M src/heap.cc View 8 chunks +182 lines, -132 lines 0 comments Download
M src/incremental-marking.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/incremental-marking.cc View 5 chunks +1 line, -15 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.status View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A test/cctest/test-gc-tracer.cc View 1 1 chunk +125 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ernstm
Re-landing with fixed unit tests and git cl format. PTAL.
6 years, 5 months ago (2014-07-24 08:28:53 UTC) #1
Hannes Payer (out of office)
lgtm
6 years, 5 months ago (2014-07-24 08:30:56 UTC) #2
Yang
On 2014/07/24 08:30:56, Hannes Payer wrote: > lgtm also update BUILD.gn please.
6 years, 5 months ago (2014-07-24 11:07:45 UTC) #3
ernstm
6 years, 5 months ago (2014-07-24 11:16:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r22593 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698