Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 411283003: Suppress a deadlock in TraceEventTestFixture.ThreadOnceBlocking (Closed)

Created:
6 years, 5 months ago by Alexander Potapenko
Modified:
6 years, 5 months ago
Reviewers:
earthdok
CC:
chromium-reviews, erikwright+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Suppress a deadlock in TraceEventTestFixture.ThreadOnceBlocking BUG=397022 TBR=earthdok@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285261

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M base/debug/tsan_suppressions.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 5 months ago (2014-07-24 07:54:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/411283003/1
6 years, 5 months ago (2014-07-24 07:57:02 UTC) #2
Alexander Potapenko
On 2014/07/24 07:57:02, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 5 months ago (2014-07-24 09:05:36 UTC) #3
commit-bot: I haz the power
Change committed as 285261
6 years, 5 months ago (2014-07-24 14:43:31 UTC) #4
Derek Bruening
I would suggest replacing the old tools/valgrind/tsan/suppressions.txt with a pointer to this file, as I ...
6 years, 5 months ago (2014-07-24 16:56:12 UTC) #5
Alexander Potapenko
6 years, 5 months ago (2014-07-24 17:33:25 UTC) #6
Message was sent while issue was closed.
On 2014/07/24 16:56:12, Derek Bruening wrote:
> I would suggest replacing the old tools/valgrind/tsan/suppressions.txt with a
> pointer to this file, as I (along with other Memory Sheriffs I pinged) was not
> aware that this base/debug/tsan_suppressions.cc file existed and that this was
> how to suppress tsan errors.  The fact that there is no suppression info in
the
> error report on the bot implied that suppressions were just not supported.

Will do. Note the suppressions are also mentioned in the TSan v2 documentation
on dev.chromium.org

Powered by Google App Engine
This is Rietveld 408576698