Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 411283002: Remove disable-embedded-shared-worker flag and shared worker process related codes. (Closed)

Created:
6 years, 5 months ago by horo
Modified:
6 years, 5 months ago
CC:
aandrey+blink_chromium.org, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, extensions-reviews_chromium.org, Ilya Sherman, jam, nasko+codewatch_chromium.org, paulirish+reviews_chromium.org, pfeldman, vsevik, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove disable-embedded-shared-worker flag and shared worker process related codes. BUG=327256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285521

Patch Set 1 #

Total comments: 2

Patch Set 2 : PROCESS_TYPE_WORKER_DEPRECATED #

Patch Set 3 : set origin_child_id of ResourceRequestDetails #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -5433 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/devtools/devtools_targets_ui.cc View 2 chunks +1 line, -22 lines 0 comments Download
M chrome/browser/memory_details.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/metrics/profiler_metrics_provider.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/performance_monitor/process_metrics_history.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/task_manager/child_process_resource_provider.cc View 1 4 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 2 3 2 chunks +0 lines, -6 lines 0 comments Download
D chrome/browser/task_manager/worker_resource_provider.h View 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/browser/task_manager/worker_resource_provider.cc View 1 chunk +0 lines, -359 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_dll.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/content_main_runner.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M content/browser/devtools/embedded_worker_devtools_manager.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M content/browser/devtools/embedded_worker_devtools_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/devtools/worker_devtools_manager.h View 1 chunk +0 lines, -110 lines 0 comments Download
D content/browser/devtools/worker_devtools_manager.cc View 1 chunk +0 lines, -453 lines 0 comments Download
D content/browser/devtools/worker_devtools_message_filter.h View 1 chunk +0 lines, -34 lines 0 comments Download
D content/browser/devtools/worker_devtools_message_filter.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/loader/resource_request_info_impl.cc View 2 chunks +2 lines, -13 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +14 lines, -33 lines 0 comments Download
M content/browser/shared_worker/shared_worker_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/shared_worker/shared_worker_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/shared_worker/shared_worker_instance.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/shared_worker/shared_worker_instance_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/shared_worker/shared_worker_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/shared_worker/shared_worker_message_filter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.cc View 1 chunk +6 lines, -1 line 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A content/browser/shared_worker/worker_browsertest.cc View 1 chunk +146 lines, -0 lines 0 comments Download
A + content/browser/shared_worker/worker_document_set.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/shared_worker/worker_document_set.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/shared_worker/worker_storage_partition.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/shared_worker/worker_storage_partition.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/worker_host/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D content/browser/worker_host/test/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D content/browser/worker_host/test/worker_browsertest.cc View 1 chunk +0 lines, -300 lines 0 comments Download
D content/browser/worker_host/worker_document_set.h View 1 chunk +0 lines, -96 lines 0 comments Download
D content/browser/worker_host/worker_document_set.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D content/browser/worker_host/worker_message_filter.h View 1 chunk +0 lines, -56 lines 0 comments Download
D content/browser/worker_host/worker_message_filter.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D content/browser/worker_host/worker_process_host.h View 1 chunk +0 lines, -293 lines 0 comments Download
D content/browser/worker_host/worker_process_host.cc View 1 chunk +0 lines, -845 lines 0 comments Download
D content/browser/worker_host/worker_service_impl.h View 1 chunk +0 lines, -121 lines 0 comments Download
D content/browser/worker_host/worker_service_impl.cc View 1 chunk +0 lines, -600 lines 0 comments Download
D content/browser/worker_host/worker_storage_partition.h View 1 chunk +0 lines, -134 lines 0 comments Download
D content/browser/worker_host/worker_storage_partition.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M content/common/process_type.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/content.gyp View 4 chunks +0 lines, -20 lines 0 comments Download
M content/content_browser.gypi View 3 chunks +4 lines, -14 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 2 3 3 chunks +1 line, -2 lines 0 comments Download
D content/content_worker.gypi View 1 chunk +0 lines, -30 lines 0 comments Download
M content/public/browser/resource_request_details.cc View 1 2 2 chunks +1 line, -14 lines 0 comments Download
M content/public/browser/worker_service.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/process_type.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D content/worker/BUILD.gn View 1 chunk +0 lines, -32 lines 0 comments Download
D content/worker/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D content/worker/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D content/worker/shared_worker_permission_client_proxy.h View 1 chunk +0 lines, -47 lines 0 comments Download
D content/worker/shared_worker_permission_client_proxy.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D content/worker/websharedworker_stub.h View 1 chunk +0 lines, -84 lines 0 comments Download
D content/worker/websharedworker_stub.cc View 1 chunk +0 lines, -146 lines 0 comments Download
D content/worker/websharedworkerclient_proxy.h View 1 chunk +0 lines, -75 lines 0 comments Download
D content/worker/websharedworkerclient_proxy.cc View 1 chunk +0 lines, -139 lines 0 comments Download
D content/worker/worker_main.cc View 1 chunk +0 lines, -74 lines 0 comments Download
D content/worker/worker_thread.h View 1 chunk +0 lines, -59 lines 0 comments Download
D content/worker/worker_thread.cc View 1 chunk +0 lines, -148 lines 0 comments Download
D content/worker/worker_webapplicationcachehost_impl.h View 1 chunk +0 lines, -36 lines 0 comments Download
D content/worker/worker_webapplicationcachehost_impl.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D content/worker/worker_webkitplatformsupport_impl.h View 1 chunk +0 lines, -128 lines 0 comments Download
D content/worker/worker_webkitplatformsupport_impl.cc View 1 chunk +0 lines, -315 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
horo
jochen@ Could you please review this? Thank you.
6 years, 5 months ago (2014-07-24 09:09:48 UTC) #1
jochen (gone - plz use gerrit)
why do you need the WORKER_PROCESS_DEPRECATED if we can't have an out of process worker ...
6 years, 5 months ago (2014-07-24 09:25:09 UTC) #2
horo
> why do you need the WORKER_PROCESS_DEPRECATED if we can't have an out of process ...
6 years, 5 months ago (2014-07-24 10:22:58 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-24 12:16:29 UTC) #4
horo
The CQ bit was checked by horo@chromium.org
6 years, 5 months ago (2014-07-24 12:46:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/411283002/80001
6 years, 5 months ago (2014-07-24 12:48:33 UTC) #6
horo
The CQ bit was unchecked by horo@chromium.org
6 years, 5 months ago (2014-07-24 13:09:32 UTC) #7
horo
derat@ Could you please review extensions/shell/app_shell.gyp? Thank you.
6 years, 5 months ago (2014-07-24 13:10:55 UTC) #8
Daniel Erat
lgtm for extensions/shell
6 years, 5 months ago (2014-07-24 13:23:44 UTC) #9
horo
The CQ bit was checked by horo@chromium.org
6 years, 5 months ago (2014-07-25 01:29:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/411283002/100001
6 years, 5 months ago (2014-07-25 01:31:39 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 07:37:53 UTC) #12
Message was sent while issue was closed. 
Change committed as 285521

Powered by Google App Engine
This is Rietveld 408576698