Incorporate reset button in post-automatic-reset settings-banner.

chrome/browser/resources/options/automatic_settings_reset_banner.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Note: the native-side handler for this is AutomaticSettingsResetHandler.
 
 cr.define('options', function() {
   /** @const */ var SettingsBannerBase = options.SettingsBannerBase;
 
   /**
@@ skipping 21 matching lines @@
 
       $('automatic-settings-reset-banner-close').onclick = function(event) {
         chrome.send('metricsHandler:recordAction',
             ['AutomaticSettingsReset_WebUIBanner_ManuallyClosed']);
         AutomaticSettingsResetBanner.dismiss();
       };
       $('automatic-settings-reset-learn-more').onclick = function(event) {
         chrome.send('metricsHandler:recordAction',
             ['AutomaticSettingsReset_WebUIBanner_LearnMoreClicked']);
       };
+      $('automatic-settings-reset-banner-activate-reset').onclick =
+          function(event) {
+            chrome.send('metricsHandler:recordAction',
+                ['AutomaticSettingsReset_WebUIBanner_ResetClicked']);
+            OptionsPage.navigateToPage('resetProfileSettings');
+          };

[robertshield, 2014/07/28 21:09:42]

not sure, but seems like this should line up with the $( on line 42. 

[gab, 2014/07/28 21:22:52]

Wasn't sure either but since I indented "function(event) {" above so I indented
this "}" to match that.

I couldn't find an example of such a wrapping caused by the onclick target's
name being too long...

UI owners will know I assume.

[Bernhard Bauer, 2014/07/28 22:29:38]

I think what you do here is indent line 43 four spaces, then continue with two
space indent for the rest of the function (and then no space for the closing
brace and semicolon).

[gab, 2014/07/29 14:54:40]

Okay so just like I have it, but bring the closing "};" back.

Done.

[Bernhard Bauer, 2014/07/29 15:01:43]

Sorry, what I meant was this:

$('foo').onclick =
    function() {
  chrome.send('moose!');
};

[gab, 2014/07/29 15:41:55]

Ah I see, thanks for clarifying, done!

     },
   };
 
   // Forward public APIs to private implementations.
   [
     'show',
     'dismiss',
   ].forEach(function(name) {
     AutomaticSettingsResetBanner[name] = function() {
       var instance = AutomaticSettingsResetBanner.getInstance();
       return instance[name + '_'].apply(instance, arguments);
     };
   });
 
   // Export
   return {
     AutomaticSettingsResetBanner: AutomaticSettingsResetBanner
   };
 });