Issue 411263003: DevTools: Extract SortableDataGrid.

Issue 411263003: DevTools: Extract SortableDataGrid. (Closed)

Created:
6 years, 5 months ago by eustas

Modified:
6 years, 5 months ago

Reviewers:
vsevik, aandrey, lushnikov

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Extract SortableDataGrid. In future SortableDataGrid will inherit from ViewportDataGrid. BUG=316092 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178905

Patch Set 1 #

Total comments: 14

Patch Set 2 : Addressed comments #

Patch Set 3 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+227 lines, -185 lines)			Patch
M	Source/devtools/devtools.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/console/ConsoleViewMessage.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/inspector.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/network/NetworkPanel.js	View	1	5 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/devtools/front_end/resources/DatabaseQueryView.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/resources/DatabaseTableView.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/resources/DirectoryContentView.js	View		6 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/devtools/front_end/ui/DataGrid.js	View		3 chunks	+0 lines, -169 lines	0 comments	Download
A	Source/devtools/front_end/ui/SortableDataGrid.js	View	1 2	1 chunk	+208 lines, -0 lines	0 comments	Download
M	Source/devtools/scripts/frontend_modules.json	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

aandrey

lgtm https://codereview.chromium.org/411263003/diff/1/Source/devtools/front_end/ui/SortableDataGrid.js File Source/devtools/front_end/ui/SortableDataGrid.js (right): https://codereview.chromium.org/411263003/diff/1/Source/devtools/front_end/ui/SortableDataGrid.js#newcode9 Source/devtools/front_end/ui/SortableDataGrid.js:9: * @param {function(!WebInspector.DataGridNode, string, string, string)=} editCallback SortableDataGridNode? ...

6 years, 5 months ago (2014-07-24 08:48:20 UTC) #2

eustas

https://codereview.chromium.org/411263003/diff/1/Source/devtools/front_end/ui/SortableDataGrid.js File Source/devtools/front_end/ui/SortableDataGrid.js (right): https://codereview.chromium.org/411263003/diff/1/Source/devtools/front_end/ui/SortableDataGrid.js#newcode9 Source/devtools/front_end/ui/SortableDataGrid.js:9: * @param {function(!WebInspector.DataGridNode, string, string, string)=} editCallback On 2014/07/24 ...

6 years, 5 months ago (2014-07-25 05:58:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/411263003/40001

6 years, 5 months ago (2014-07-25 06:14:24 UTC) #6

Message was sent while issue was closed.

Change committed as 178905

Expand Messages | Collapse Messages