Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 411253010: android tests: don't override DIR_MODULE (take 2) (Closed)

Created:
6 years, 5 months ago by tim (not reviewing)
Modified:
6 years, 5 months ago
Reviewers:
nyquist, brettw, sky
CC:
chromium-reviews, erikwright+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

android tests: don't override DIR_MODULE (take 2) another attempt at https://codereview.chromium.org/408063002/ to try fixing the iOS Simulator:URLFixerTest failures writing to DIR_TEST_DATA. R=nyquist@chromium.org TBR=brettw@chromium.org, nyquist@chromium.org, sky@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285451

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -23 lines) Patch
M base/test/test_support_android.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_paths.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M components/url_fixer/url_fixer_unittest.cc View 7 chunks +23 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tim (not reviewing)
TBR reviewers; Only change from previous is I'm trying to satisfy iOS Simulator by picking ...
6 years, 5 months ago (2014-07-24 18:48:54 UTC) #1
tim (not reviewing)
The CQ bit was checked by tim@chromium.org
6 years, 5 months ago (2014-07-24 19:48:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/411253010/1
6 years, 5 months ago (2014-07-24 19:51:09 UTC) #3
nyquist
lgtm
6 years, 5 months ago (2014-07-24 21:08:46 UTC) #4
sky
In the future please upload the original patch (sync'ed to trunk) followed by the fix. ...
6 years, 5 months ago (2014-07-24 22:15:27 UTC) #5
tim (not reviewing)
noted! thanks for the tip. On Thu, Jul 24, 2014 at 3:15 PM, <sky@chromium.org> wrote: ...
6 years, 5 months ago (2014-07-24 22:33:06 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 23:04:15 UTC) #7
tim (not reviewing)
On 2014/07/24 23:04:15, I haz the power (commit-bot) wrote: > FYI, CQ is re-trying this ...
6 years, 5 months ago (2014-07-25 01:51:55 UTC) #8
tim (not reviewing)
6 years, 5 months ago (2014-07-25 01:53:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r285451 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698