Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 411253009: Remove obsolete GuestWebContentsObserver reference (Closed)

Created:
6 years, 5 months ago by lazyboy
Modified:
6 years, 5 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Remove obsolete GuestWebContentsObserver reference BUG=None Test=None, internal cleanup. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/guest_view/guest_view_manager.h View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
lazyboy
6 years, 5 months ago (2014-07-24 17:54:21 UTC) #1
Fady Samuel
lgtm
6 years, 5 months ago (2014-07-24 17:56:44 UTC) #2
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 5 months ago (2014-07-24 17:58:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/411253009/1
6 years, 5 months ago (2014-07-24 18:01:40 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 22:00:58 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 22:33:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/2127)
6 years, 5 months ago (2014-07-24 22:33:31 UTC) #7
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 5 months ago (2014-07-25 08:57:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/411253009/1
6 years, 5 months ago (2014-07-25 08:59:10 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 10:07:58 UTC) #10
Message was sent while issue was closed. 
Change committed as 285550

Powered by Google App Engine
This is Rietveld 408576698