Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 411253008: dom distiller: extract markup properties from protobuf (Closed)

Created:
6 years, 5 months ago by kuan
Modified:
6 years, 5 months ago
Reviewers:
Yaron
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

dom distiller: extract markup properties from protobuf - store the properties into DistilledPageInfo - add test using OpenGraphProtocol and Schema.Org markup. BUG=396124 TBR=nyquist Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -0 lines) Patch
M components/dom_distiller/content/distiller_page_web_contents_browsertest.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M components/dom_distiller/core/distiller_page.h View 1 chunk +40 lines, -0 lines 0 comments Download
M components/dom_distiller/core/distiller_page.cc View 2 chunks +46 lines, -0 lines 0 comments Download
A components/test/data/dom_distiller/markup_article.html View 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kuan
6 years, 5 months ago (2014-07-24 14:11:56 UTC) #1
Yaron
lgtm
6 years, 5 months ago (2014-07-25 01:42:28 UTC) #2
kuan
The CQ bit was checked by kuan@chromium.org
6 years, 5 months ago (2014-07-25 01:43:00 UTC) #3
kuan
The CQ bit was unchecked by kuan@chromium.org
6 years, 5 months ago (2014-07-25 01:43:31 UTC) #4
kuan
The CQ bit was checked by kuan@chromium.org
6 years, 5 months ago (2014-07-25 01:46:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kuan@chromium.org/411253008/1
6 years, 5 months ago (2014-07-25 02:26:04 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 08:40:51 UTC) #7
Message was sent while issue was closed.
Change committed as 285533

Powered by Google App Engine
This is Rietveld 408576698