Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 411253002: Fix flaky WindowsApiSetIcon test. (Closed)

Created:
6 years, 5 months ago by benwells
Modified:
6 years, 5 months ago
Reviewers:
calamity
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix flaky WindowsApiSetIcon test. BUG=396466 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/extensions/api/app_window/app_window_apitest.cc View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/test/data/extensions/platform_apps/windows_api_set_icon/background.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
benwells
6 years, 5 months ago (2014-07-24 22:59:08 UTC) #1
calamity
lgtm
6 years, 5 months ago (2014-07-25 06:52:31 UTC) #2
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 5 months ago (2014-07-25 09:01:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/411253002/1
6 years, 5 months ago (2014-07-25 09:03:55 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 09:47:36 UTC) #5
Message was sent while issue was closed.
Change committed as 285545

Powered by Google App Engine
This is Rietveld 408576698