Request video element to enter fullscreen when playing protected content

content/browser/media/android/browser_media_player_manager.cc

Index: content/browser/media/android/browser_media_player_manager.cc
diff --git a/content/browser/media/android/browser_media_player_manager.cc b/content/browser/media/android/browser_media_player_manager.cc
index 02e90b4b611b648c57e80076121753aa0e29615e..3529ebe2018911be013b98e20a78245417f6fee3 100644
--- a/content/browser/media/android/browser_media_player_manager.cc
+++ b/content/browser/media/android/browser_media_player_manager.cc
@@ -17,6 +17,7 @@
 #include "content/public/browser/storage_partition.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_delegate.h"
+#include "content/public/common/content_switches.h"
 #include "media/base/android/media_drm_bridge.h"
 #include "media/base/android/media_player_bridge.h"
 #include "media/base/android/media_source_player.h"
@@ -325,7 +326,13 @@ void BrowserMediaPlayerManager::OnProtectedSurfaceRequested(int player_id) {
     return;
   }
 
-  OnEnterFullscreen(player_id);
+  // Request the video element to enter fullscreen if there is no gesture
+  // requirement.
+  // TODO(qinmin): make this flag default on android.
+  if (CommandLine::ForCurrentProcess()->HasSwitch(
+      switches::kDisableGestureRequirementForMediaFullscreen)) {
+    Send(new MediaPlayerMsg_RequestFullscreen(routing_id(), player_id));
+  }

[xhwang, 2013/10/25 18:21:59]

newbie question: How is this related to OnEnterFullscreen on l.403? Also we have
DisableFullscreenEncryptedMediaPlayback(). Can we have some doc/notes about how
the fullscreen workflow works in different scenarios?

[qinmin, 2013/10/25 20:06:13]

So when this IPC gets sent to the render process, it allows blink go through all
the renderFullscreen code path to make sure we are using the correct rendering
mode for the video. And onEnterFullscreen() will be called afterwards.

DisableFullscreenEncryptedMediaPlayback() is a temporary thing. If it is called
before OnEnterFullscreen(), we will wait until GenerateKeyIfAllowed() to retry
the whole fullscreen logic. If it is called after OnEnterFullscreen(), then the
player will enter fullscreen first, and then quit afterwards.

updated the comments above.
On 2013/10/25 18:21:59, xhwang wrote:

 }
 
 void BrowserMediaPlayerManager::OnKeyAdded(int media_keys_id,