Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 411143006: Update GCDPrivate API permissions and fix tests (Closed)

Created:
6 years, 5 months ago by Noam Samuel
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Update GCDPrivate API permissions and fix tests 1. Update GCDPrivate to be on dev mode, with whitelist for approved extensions 2. Fix the tests to match BUG=394124 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285648

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/gcd_private/api/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
Noam Samuel
Kalman: This replaces https://codereview.chromium.org/399503002/
6 years, 5 months ago (2014-07-24 20:44:52 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 5 months ago (2014-07-24 20:52:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/411143006/1
6 years, 5 months ago (2014-07-24 20:56:49 UTC) #3
not at google - send to devlin
lgtm
6 years, 5 months ago (2014-07-24 21:07:57 UTC) #4
Noam Samuel
The CQ bit was unchecked by noamsml@chromium.org
6 years, 5 months ago (2014-07-24 21:08:23 UTC) #5
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 5 months ago (2014-07-24 21:08:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/411143006/1
6 years, 5 months ago (2014-07-24 21:09:49 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 22:42:44 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 22:44:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/33016)
6 years, 5 months ago (2014-07-24 22:44:49 UTC) #10
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 5 months ago (2014-07-24 23:39:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/411143006/20001
6 years, 5 months ago (2014-07-24 23:41:39 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 05:39:52 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 06:17:24 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/2295)
6 years, 5 months ago (2014-07-25 06:17:26 UTC) #15
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 5 months ago (2014-07-25 17:42:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/411143006/40001
6 years, 5 months ago (2014-07-25 17:44:20 UTC) #17
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 19:55:55 UTC) #18
Message was sent while issue was closed.
Change committed as 285648

Powered by Google App Engine
This is Rietveld 408576698