runtime/vm/parser.cc - Issue 41113002: Properly report error for certain expressions that must be const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser.cc

Issue 41113002: Properly report error for certain expressions that must be const (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/parser.cc

===================================================================

--- runtime/vm/parser.cc (revision 29136)

+++ runtime/vm/parser.cc (working copy)

@@ -7862,8 +7862,11 @@

LiteralNode* Parser::ParseConstExpr() {

TRACE_PARSER("ParseConstExpr");

+ intptr_t expr_pos = TokenPos();

AstNode* expr = ParseExpr(kRequireConst, kNoCascades);

- ASSERT(expr->IsLiteralNode());

+ if (!expr->IsLiteralNode()) {

+ ErrorMsg(expr_pos, "expression must be a compile-time constant");

+ }

return expr->AsLiteralNode();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »