Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 411093002: Make AppSyncUIStateFactory depends on ExtensionRegistryFactory (Closed)

Created:
6 years, 5 months ago by limasdf
Modified:
6 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make AppSyncUIStateFactory depends on ExtensionRegistryFactory Now AppSyncUIState has ExtensionRegistry to listen extesnions's notification To make sure ExtesnionRegistry is destroyed after AppSyncUIState. AppSyncUIStateFactory should depends on ExtensionRegistryFactory. BUG=354046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285150

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/ash/app_sync_ui_state_factory.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
limasdf
PTAL. Sorry, This is excluded from patch set 2 -> 3 by mistake :( https://codereview.chromium.org/403843005/
6 years, 5 months ago (2014-07-23 20:57:51 UTC) #1
James Cook
lgtm
6 years, 5 months ago (2014-07-23 21:03:16 UTC) #2
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 5 months ago (2014-07-23 21:30:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/411093002/1
6 years, 5 months ago (2014-07-23 21:34:39 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 01:35:39 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 03:58:16 UTC) #6
Message was sent while issue was closed.
Change committed as 285150

Powered by Google App Engine
This is Rietveld 408576698