Combine BrowserActionView and BrowserActionButton

Combine BrowserActionView and BrowserActionButton

No one seems to know why we have BrowserActionView and BrowserActionButton.
Let's combine them for simplicity.

BUG=402526
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289092

[Devlin, 2014-08-11 17:42:24]

Finnur and Peter, please take a look when you can.

[Peter Kasting, 2014-08-11 22:19:38]

LGTM

https://codereview.chromium.org/411063003/diff/20001/chrome/browser/ui/views/...
File
chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
(right):

https://codereview.chromium.org/411063003/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc:246:
const std::string& id = view->extension()->id();
Nit: I'd just inline this into the lone usage below.

https://codereview.chromium.org/411063003/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/toolbar/browser_action_view.h (right):

https://codereview.chromium.org/411063003/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/toolbar/browser_action_view.h:41: // Need DragController
here because an BrowserActionView could be
Nit: an -> a (or just leave it out, the old comment was OK)

[Devlin, 2014-08-11 23:30:32]

https://codereview.chromium.org/411063003/diff/20001/chrome/browser/ui/views/...
File
chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
(right):

https://codereview.chromium.org/411063003/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc:246:
const std::string& id = view->extension()->id();
On 2014/08/11 22:19:37, Peter Kasting wrote:
> Nit: I'd just inline this into the lone usage below.

Works for me. Done.

https://codereview.chromium.org/411063003/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/toolbar/browser_action_view.h (right):

https://codereview.chromium.org/411063003/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/toolbar/browser_action_view.h:41: // Need DragController
here because an BrowserActionView could be
On 2014/08/11 22:19:37, Peter Kasting wrote:
> Nit: an -> a (or just leave it out, the old comment was OK)

Whoops!  Leftover from a discarded change.  Removed.

[Finnur, 2014-08-12 11:36:32]

LGTM. 

As a good measure (if you haven't already), search for BrowserActionButton in
the code and see if it is mentioned somewhere in a comment or something.

[Devlin, 2014-08-12 14:07:12]

On 2014/08/12 11:36:32, Finnur wrote:
> LGTM. 
> 
> As a good measure (if you haven't already), search for BrowserActionButton in
> the code and see if it is mentioned somewhere in a comment or something.

Already did. :)  The remaining references are all to the cocoa
BrowserActionButton (ui/cocoa/extensions/browser_action_button.h).

[Devlin, 2014-08-12 14:07:16]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-08-12 14:09:41]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/411063003/...

[commit-bot: I haz the power, 2014-08-12 19:10:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-12 22:42:16]

Change committed as 289092