Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 411053002: Remove bookmarks API client-side write operations limits (Closed)

Created:
6 years, 5 months ago by Mike Wittman
Modified:
6 years, 5 months ago
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, tim (not reviewing), Nicolas Zea
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Project:
chromium
Visibility:
Public.

Description

Remove bookmarks API client-side write operations limits Server-side throttling is sufficient to avoid abuse of the bookmarks API. BUG=307982 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285180

Patch Set 1 #

Total comments: 4

Patch Set 2 : restore properties as deprecated and remove additional code #

Total comments: 2

Patch Set 3 : remove property descriptions #

Patch Set 4 : remove quota tests #

Patch Set 5 : fully remove test helper #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -302 lines) Patch
M chrome/browser/extensions/api/bookmarks/bookmarks_api.h View 4 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.cc View 1 4 chunks +0 lines, -202 lines 0 comments Download
M chrome/common/extensions/api/bookmarks.json View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/bookmarks/test.js View 1 2 3 2 chunks +0 lines, -51 lines 0 comments Download
M extensions/browser/api/test/test_api.h View 1 2 3 1 chunk +0 lines, -11 lines 0 comments Download
M extensions/browser/api/test/test_api.cc View 1 2 3 2 chunks +0 lines, -11 lines 0 comments Download
M extensions/browser/quota_service.h View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/common/api/test.json View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Mike Wittman
6 years, 5 months ago (2014-07-23 19:11:14 UTC) #1
not at google - send to devlin
https://codereview.chromium.org/411053002/diff/1/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc File chrome/browser/extensions/api/bookmarks/bookmarks_api.cc (right): https://codereview.chromium.org/411053002/diff/1/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc#newcode827 chrome/browser/extensions/api/bookmarks/bookmarks_api.cc:827: class CreateBookmarkBucketMapper : public BookmarkBucketMapper<std::string> { you can delete ...
6 years, 5 months ago (2014-07-23 19:15:22 UTC) #2
not at google - send to devlin
https://codereview.chromium.org/411053002/diff/1/chrome/common/extensions/api/bookmarks.json File chrome/common/extensions/api/bookmarks.json (left): https://codereview.chromium.org/411053002/diff/1/chrome/common/extensions/api/bookmarks.json#oldcode10 chrome/common/extensions/api/bookmarks.json:10: "MAX_WRITE_OPERATIONS_PER_HOUR": { oh and instead of removing this can ...
6 years, 5 months ago (2014-07-23 19:17:43 UTC) #3
Mike Wittman
https://codereview.chromium.org/411053002/diff/1/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc File chrome/browser/extensions/api/bookmarks/bookmarks_api.cc (right): https://codereview.chromium.org/411053002/diff/1/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc#newcode827 chrome/browser/extensions/api/bookmarks/bookmarks_api.cc:827: class CreateBookmarkBucketMapper : public BookmarkBucketMapper<std::string> { On 2014/07/23 19:15:22, ...
6 years, 5 months ago (2014-07-23 19:42:53 UTC) #4
not at google - send to devlin
lgtm https://codereview.chromium.org/411053002/diff/20001/chrome/common/extensions/api/bookmarks.json File chrome/common/extensions/api/bookmarks.json (right): https://codereview.chromium.org/411053002/diff/20001/chrome/common/extensions/api/bookmarks.json#newcode18 chrome/common/extensions/api/bookmarks.json:18: "description": "The maximum number of <code>move</code>, <code>update</code>, <code>create</code>, ...
6 years, 5 months ago (2014-07-23 19:47:33 UTC) #5
Mike Wittman
https://codereview.chromium.org/411053002/diff/20001/chrome/common/extensions/api/bookmarks.json File chrome/common/extensions/api/bookmarks.json (right): https://codereview.chromium.org/411053002/diff/20001/chrome/common/extensions/api/bookmarks.json#newcode18 chrome/common/extensions/api/bookmarks.json:18: "description": "The maximum number of <code>move</code>, <code>update</code>, <code>create</code>, or ...
6 years, 5 months ago (2014-07-23 20:07:32 UTC) #6
Mike Wittman
The CQ bit was checked by wittman@chromium.org
6 years, 5 months ago (2014-07-23 20:07:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wittman@chromium.org/411053002/60001
6 years, 5 months ago (2014-07-23 20:09:21 UTC) #8
Mike Wittman
The CQ bit was unchecked by wittman@chromium.org
6 years, 5 months ago (2014-07-23 22:32:19 UTC) #9
Mike Wittman
The CQ bit was checked by wittman@chromium.org
6 years, 5 months ago (2014-07-23 22:35:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wittman@chromium.org/411053002/80001
6 years, 5 months ago (2014-07-23 22:36:53 UTC) #11
Mike Wittman
The CQ bit was unchecked by wittman@chromium.org
6 years, 5 months ago (2014-07-23 22:59:38 UTC) #12
Mike Wittman
The CQ bit was checked by wittman@chromium.org
6 years, 5 months ago (2014-07-23 23:01:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wittman@chromium.org/411053002/100001
6 years, 5 months ago (2014-07-23 23:03:25 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 10:58:28 UTC) #15
Message was sent while issue was closed. 
Change committed as 285180

Powered by Google App Engine
This is Rietveld 408576698