Issue 411005: Merge r32515 from trunk to 249 branch...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 411005: Merge r32515 from trunk to 249 branch... (Closed)

Created:
11 years, 1 month ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
TVL

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/249/src/

Visibility:
Public.

Description

Merge r32515 from trunk to 249 branch Mac language/locale cleanup Effectively revert revision 28193 (http://codereview.chromium.org/258037), this makes Mac match the other platform for what at it's core is used for the chrome concept of locale. For the ApplicationLanguage, the browser will end up with what Cocoa picks (same as before) All other process types will honor the language they got on the command line when starting up. When asked the apps language, have the same side effect as Windows and Linux has of pushing the language through to ICU also (so dates format right, etc.) During browser startup, if someone passed a language, bail because Mac can't support that. TEST=The tips on the NTP and the dates on the history page are in the same language at the UI. BUG=26856 BUG=22727 Review URL: http://codereview.chromium.org/399086 TBR=thomasvl@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32564

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+96 lines, -36 lines)			Patch
M	app/l10n_util.cc	View	3 chunks	+32 lines, -7 lines	0 comments	Download
M	app/l10n_util_mac.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	app/l10n_util_mac.mm	View	1 chunk	+48 lines, -5 lines	0 comments	Download
M	chrome/browser/browser_main_mac.mm	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/tips_handler.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/web_resource/web_resource_service.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/web_resource/web_resource_service.cc	View	2 chunks	+3 lines, -18 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages