Issue 411004: Special case the gallery to not show the scary download roadblock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 411004: Special case the gallery to not show the scary download roadblock. (Closed)

Created:
11 years, 1 month ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
asargent_no_longer_on_chrome, abarth-chromium

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Special case the gallery to not show the scary download roadblock. That was only needed because of clickjacking. BUG=28227 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32588

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+249 lines, -25 lines)			Patch
M	chrome/browser/dom_ui/new_tab_ui.cc	View	1	2 chunks	+212 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service.h	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service.cc	View		1 chunk	+13 lines, -9 lines	0 comments	Download
M	chrome/browser/extensions/extensions_ui.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/extension_constants.h	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_constants.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

asargent_no_longer_on_chrome

Perhaps add a comment about the difference between the gallery and mini gallery. Otherwise lgtm.

11 years, 1 month ago (2009-11-19 21:28:14 UTC) #3

abarth-chromium

This conflicts with a change I have in flight, but otherwise seems ok.

11 years, 1 month ago (2009-11-19 21:49:02 UTC) #4

abarth-chromium

11 years, 1 month ago (2009-11-19 21:52:31 UTC) #5

Landed conflicting change in
http://src.chromium.org/viewvc/chrome?view=rev&revision=32550.