Source/core/css/parser/CSSPropertyParser.cpp - Issue 410953002: Merge CSSProperties.in and CSSShorthands.in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 410953002: Merge CSSProperties.in and CSSShorthands.in (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@infiles

Patch Set: err on safe side for devtools parsing longhands Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/parser/CSSPropertyParser.cpp

diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp

index 7ca9e185a809bc99bfd4f577b9c3d53151ea0e07..c8447b9477e1eb35691465bf65945571755dd78f 100644

--- a/Source/core/css/parser/CSSPropertyParser.cpp

+++ b/Source/core/css/parser/CSSPropertyParser.cpp

@@ -168,7 +168,7 @@ void CSSPropertyParser::addProperty(CSSPropertyID propId, PassRefPtrWillBeRawPtr

Vector<StylePropertyShorthand, 4> shorthands;

getMatchingShorthandsForLonghand(propId, &shorthands);

// Viewport descriptors have width and height as shorthands, but it doesn't

- // make sense for CSSShorthands.in to consider them as such. The shorthand

+ // make sense for CSSProperties.in to consider them as such. The shorthand

// index is only used by the inspector and doesn't affect viewport

// descriptors.

if (shorthands.isEmpty())