Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: tools/relocation_packer/src/packer.cc

Issue 410933004: Extend relocation packing to cover arm64. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to master Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/relocation_packer/src/packer.h ('k') | tools/relocation_packer/src/packer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/relocation_packer/src/packer.cc
diff --git a/tools/relocation_packer/src/packer.cc b/tools/relocation_packer/src/packer.cc
index c1d986260c4044dcf1987fa224b40d0055fa5199..29bec1e3c647a21298c6097f372239a32da0e8f5 100644
--- a/tools/relocation_packer/src/packer.cc
+++ b/tools/relocation_packer/src/packer.cc
@@ -7,18 +7,19 @@
#include <vector>
#include "debug.h"
+#include "delta_encoder.h"
#include "elf_traits.h"
#include "leb128.h"
#include "run_length_encoder.h"
+#include "sleb128.h"
namespace relocation_packer {
-// Pack ARM relative relocations into a run-length encoded packed
+// Pack relative relocations into a run-length encoded packed
// representation.
void RelocationPacker::PackRelativeRelocations(
const std::vector<ELF::Rel>& relocations,
std::vector<uint8_t>* packed) {
-
// Run-length encode.
std::vector<ELF::Xword> packed_words;
RelocationRunLengthCodec codec;
@@ -45,17 +46,18 @@ void RelocationPacker::PackRelativeRelocations(
packed->push_back(0);
}
-// Unpack ARM relative relocations from a run-length encoded packed
+// Unpack relative relocations from a run-length encoded packed
// representation.
void RelocationPacker::UnpackRelativeRelocations(
const std::vector<uint8_t>& packed,
std::vector<ELF::Rel>* relocations) {
-
// LEB128 decode, after checking and stripping "APR1" prefix.
std::vector<ELF::Xword> packed_words;
Leb128Decoder decoder(packed);
- CHECK(decoder.Dequeue() == 'A' && decoder.Dequeue() == 'P' &&
- decoder.Dequeue() == 'R' && decoder.Dequeue() == '1');
+ CHECK(decoder.Dequeue() == 'A' &&
+ decoder.Dequeue() == 'P' &&
+ decoder.Dequeue() == 'R' &&
+ decoder.Dequeue() == '1');
decoder.DequeueAll(&packed_words);
// Run-length decode.
@@ -63,4 +65,60 @@ void RelocationPacker::UnpackRelativeRelocations(
codec.Decode(packed_words, relocations);
}
+// Pack relative relocations with addends into a delta encoded packed
+// representation.
+void RelocationPacker::PackRelativeRelocations(
+ const std::vector<ELF::Rela>& relocations,
+ std::vector<uint8_t>* packed) {
+ // Delta encode.
+ std::vector<ELF::Sxword> packed_words;
+ RelocationDeltaCodec codec;
+ codec.Encode(relocations, &packed_words);
+
+ // If insufficient data to delta encode, do nothing.
+ if (packed_words.empty())
+ return;
+
+ // Signed LEB128 encode, with "APA1" prefix. ASCII does not encode as
+ // itself under signed LEB128, so we have to treat it specially.
+ Sleb128Encoder encoder;
+ encoder.EnqueueAll(packed_words);
+ std::vector<uint8_t> encoded;
+ encoder.GetEncoding(&encoded);
+
+ packed->push_back('A');
+ packed->push_back('P');
+ packed->push_back('A');
+ packed->push_back('1');
+ packed->insert(packed->end(), encoded.begin(), encoded.end());
+
+ // Pad packed to a whole number of words. This padding will decode as
+ // signed LEB128 zeroes. Delta decoding ignores it because encoding
+ // embeds the pairs count in the stream itself.
+ while (packed->size() % sizeof(ELF::Word))
+ packed->push_back(0);
+}
+
+// Unpack relative relocations with addends from a delta encoded
+// packed representation.
+void RelocationPacker::UnpackRelativeRelocations(
+ const std::vector<uint8_t>& packed,
+ std::vector<ELF::Rela>* relocations) {
+ // Check "APA1" prefix.
+ CHECK(packed.at(0) == 'A' &&
+ packed.at(1) == 'P' &&
+ packed.at(2) == 'A' &&
+ packed.at(3) == '1');
+
+ // Signed LEB128 decode, after stripping "APA1" prefix.
+ std::vector<ELF::Sxword> packed_words;
+ std::vector<uint8_t> stripped(packed.begin() + 4, packed.end());
+ Sleb128Decoder decoder(stripped);
+ decoder.DequeueAll(&packed_words);
+
+ // Delta decode.
+ RelocationDeltaCodec codec;
+ codec.Decode(packed_words, relocations);
+}
+
} // namespace relocation_packer
« no previous file with comments | « tools/relocation_packer/src/packer.h ('k') | tools/relocation_packer/src/packer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698