Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 410923003: Fix accessors to use holder instead of this (Closed)

Created:
6 years, 5 months ago by arv (Not doing code reviews)
Modified:
6 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

The accessors should get the value from the holder and not from this. These are all data properties and if they get invoked it means that they should just return the value of the property from the holder. BUG=v8:3461 LOG=Y R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22575

Patch Set 1 #

Patch Set 2 : Update the rest of the getters #

Total comments: 4

Patch Set 3 : Remove invalid assert and fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -115 lines) Patch
M src/accessors.cc View 1 2 9 chunks +43 lines, -115 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
arv (Not doing code reviews)
6 years, 5 months ago (2014-07-23 14:59:16 UTC) #1
Toon Verwaest
lgtm
6 years, 5 months ago (2014-07-23 15:10:37 UTC) #2
arv (Not doing code reviews)
Update the rest of the getters
6 years, 5 months ago (2014-07-23 16:34:34 UTC) #3
arv (Not doing code reviews)
PTAL This now passes all the unscopables test I have in 384963002 as well as ...
6 years, 5 months ago (2014-07-23 16:40:21 UTC) #4
Toon Verwaest
LGTM if you fix the test failure (test/mjsunit/regress/regress-1062422.js) https://codereview.chromium.org/410923003/diff/20001/src/accessors.cc File src/accessors.cc (right): https://codereview.chromium.org/410923003/diff/20001/src/accessors.cc#newcode250 src/accessors.cc:250: ASSERT(value->IsJSObject()); ...
6 years, 5 months ago (2014-07-23 16:56:29 UTC) #5
arv (Not doing code reviews)
Remove invalid assert and fix comment
6 years, 5 months ago (2014-07-23 17:01:17 UTC) #6
arv (Not doing code reviews)
Updated. Would you mind landing this for me when you get the chance? Thanks. https://codereview.chromium.org/410923003/diff/20001/src/accessors.cc ...
6 years, 5 months ago (2014-07-23 17:03:39 UTC) #7
Toon Verwaest
6 years, 5 months ago (2014-07-23 20:11:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r22575 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698