Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 410923002: Fix installer variable name bugaboo. (Closed)

Created:
6 years, 5 months ago by grt (UTC plus 2)
Modified:
6 years, 5 months ago
Reviewers:
gab
CC:
chromium-reviews, grt+watch_chromium.org, Nico
Project:
chromium
Visibility:
Public.

Description

Fix installer variable name bugaboo. This is a rare codepath used only by Chrome Frame uninstalls. It's rare that it will be hit now, but leave correct code in place until the great installer GCF cleanup rather than remove this one small piece now. BUG=NONE R=gab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/installer/setup/uninstall.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
grt (UTC plus 2)
6 years, 5 months ago (2014-07-23 13:30:38 UTC) #1
gab
lgtm
6 years, 5 months ago (2014-07-23 13:59:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/410923002/1
6 years, 5 months ago (2014-07-23 14:00:09 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 15:06:05 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 16:16:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/173839)
6 years, 5 months ago (2014-07-23 16:16:51 UTC) #6
gab
The CQ bit was checked by gab@chromium.org
6 years, 5 months ago (2014-07-23 16:18:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/410923002/1
6 years, 5 months ago (2014-07-23 16:19:22 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 19:45:30 UTC) #9
Message was sent while issue was closed.
Change committed as 285017

Powered by Google App Engine
This is Rietveld 408576698