Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 410893002: Make landmines work on the first landmine. (Closed)

Created:
6 years, 5 months ago by Michael Achenbach
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Make landmines work on the first landmine. With the original script, landmines don't work if the initial commit of the landmine script and the first landmine are in the same build. In this case, the landmine file wouldn't exist yet and no landmine would be triggered. But the updated landmine content would have still been written, omitting the landmine. Now, the script will initialize an empty landmine file if none exists. This will make sure that a landmine is set on the branch builders after the next branch point. This also adds some debugging output to better trace when landmines are set/deleted. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22557

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M build/landmines.py View 1 chunk +20 lines, -15 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
PTAL
6 years, 5 months ago (2014-07-23 11:03:03 UTC) #1
Jakob Kummerow
lgtm https://codereview.chromium.org/410893002/diff/1/build/landmines.py File build/landmines.py (right): https://codereview.chromium.org/410893002/diff/1/build/landmines.py#newcode75 build/landmines.py:75: print "Setting landmine: %s" % triggered are you ...
6 years, 5 months ago (2014-07-23 11:05:48 UTC) #2
Michael Achenbach
On 2014/07/23 11:05:48, Jakob wrote: > lgtm > > https://codereview.chromium.org/410893002/diff/1/build/landmines.py > File build/landmines.py (right): > ...
6 years, 5 months ago (2014-07-23 11:21:50 UTC) #3
Michael Achenbach
6 years, 5 months ago (2014-07-23 11:33:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r22557 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698