Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 410853002: Fix member pointer callbacks in an ATL sink map (Closed)

Created:
6 years, 5 months ago by Reid Kleckner
Modified:
6 years, 5 months ago
Reviewers:
Nico, Wez, dcaiafa
CC:
chromium-reviews, chromoting-reviews_chromium.org, dcaiafa
Project:
chromium
Visibility:
Public.

Description

Fix member pointer callbacks in an ATL sink map Clang won't let you form a pointer to member without an explicit '&ClassName::' before the method name. In fact, neither will MSVC unless you explicitly disable the error, which the ATL does. This has been documented on MSDN since VS 2005: http://msdn.microsoft.com/en-us/library/ms174271.aspx Clang doesn't implement this extension, so just fix the code. R=wez@chromium.org BUG=82385 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285118

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M remoting/host/win/rdp_client_window.h View 1 chunk +10 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Reid Kleckner
6 years, 5 months ago (2014-07-23 02:55:12 UTC) #1
Wez
LGTM - adding dcaiafa@ FHI
6 years, 5 months ago (2014-07-23 05:02:09 UTC) #2
dcaiafa
lgtm
6 years, 5 months ago (2014-07-23 15:27:50 UTC) #3
Reid Kleckner
The CQ bit was checked by rnk@chromium.org
6 years, 5 months ago (2014-07-23 18:42:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@chromium.org/410853002/1
6 years, 5 months ago (2014-07-23 18:43:50 UTC) #5
commit-bot: I haz the power
Change committed as 285118
6 years, 5 months ago (2014-07-24 02:34:05 UTC) #6
Nico
Yay! Should we define _ATL_ENABLE_PTM_WARNING then?
6 years, 5 months ago (2014-07-24 03:12:27 UTC) #7
Reid Kleckner
6 years, 5 months ago (2014-07-24 16:34:49 UTC) #8
Message was sent while issue was closed.
On 2014/07/24 03:12:27, Nico (away) wrote:
> Yay!
> 
> Should we define _ATL_ENABLE_PTM_WARNING then?

We could, if you think it's OK to pile on one more gyp define.  :)

Powered by Google App Engine
This is Rietveld 408576698