Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: mojo/system/simple_dispatcher_unittest.cc

Issue 410843003: Disable all the tests that are flaking more than 5% on Windows builders. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/system/message_pipe_dispatcher_unittest.cc ('k') | net/disk_cache/backend_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/system/simple_dispatcher_unittest.cc
diff --git a/mojo/system/simple_dispatcher_unittest.cc b/mojo/system/simple_dispatcher_unittest.cc
index 83692b7c321d44f0d1b6b70a5a74e811d14275d7..648cab9f5f3461748481abe28bfe449f288cef92 100644
--- a/mojo/system/simple_dispatcher_unittest.cc
+++ b/mojo/system/simple_dispatcher_unittest.cc
@@ -87,7 +87,13 @@ class MockSimpleDispatcher : public SimpleDispatcher {
DISALLOW_COPY_AND_ASSIGN(MockSimpleDispatcher);
};
-TEST(SimpleDispatcherTest, Basic) {
+#if defined(OS_WIN)
+// http://crbug.com/396404
+#define MAYBE_Basic DISABLED_Basic
+#else
+#define MAYBE_Basic Basic
+#endif
+TEST(SimpleDispatcherTest, MAYBE_Basic) {
test::Stopwatch stopwatch;
scoped_refptr<MockSimpleDispatcher> d(new MockSimpleDispatcher());
@@ -268,7 +274,13 @@ TEST(SimpleDispatcherTest, BasicClosed) {
// Don't need to remove waiters from closed dispatchers.
}
-TEST(SimpleDispatcherTest, BasicThreaded) {
+#if defined(OS_WIN)
+// http://crbug.com/396393
+#define MAYBE_BasicThreaded DISABLED_BasicThreaded
+#else
+#define MAYBE_BasicThreaded BasicThreaded
+#endif
+TEST(SimpleDispatcherTest, MAYBE_BasicThreaded) {
test::Stopwatch stopwatch;
bool did_wait;
MojoResult result;
@@ -381,7 +393,13 @@ TEST(SimpleDispatcherTest, BasicThreaded) {
EXPECT_EQ(MOJO_RESULT_DEADLINE_EXCEEDED, result);
}
-TEST(SimpleDispatcherTest, MultipleWaiters) {
+#if defined(OS_WIN)
+// http://crbug.com/387124
+#define MAYBE_MultipleWaiters DISABLED_MultipleWaiters
+#else
+#define MAYBE_MultipleWaiters MultipleWaiters
+#endif
+TEST(SimpleDispatcherTest, MAYBE_MultipleWaiters) {
static const uint32_t kNumWaiters = 20;
bool did_wait[kNumWaiters];
« no previous file with comments | « mojo/system/message_pipe_dispatcher_unittest.cc ('k') | net/disk_cache/backend_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698