Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 410843002: Files.app: Hide fake entries for the save dialog. (Closed)

Created:
6 years, 5 months ago by hirono
Modified:
6 years, 5 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Files.app: Hide fake entries for the save dialog. Fake entries are readonly and it is not useful for the save dialog. BUG=396179 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284874

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M ui/file_manager/file_manager/foreground/js/directory_tree.js View 1 4 chunks +16 lines, -5 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 5 months ago (2014-07-23 01:42:38 UTC) #1
yoshiki
lgtm
6 years, 5 months ago (2014-07-23 01:48:42 UTC) #2
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 5 months ago (2014-07-23 01:50:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/410843002/20001
6 years, 5 months ago (2014-07-23 01:52:13 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 03:46:20 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 06:56:39 UTC) #6
Message was sent while issue was closed.
Change committed as 284874

Powered by Google App Engine
This is Rietveld 408576698