Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Issue 410833002: media/win: Make TypeEnumerator FINAL. (Closed)

Created:
6 years, 5 months ago by Nico
Modified:
6 years, 5 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

media/win: Make TypeEnumerator FINAL. Fixes this warning: In file included from ..\..\media/video/capture/win/pin_base_win.h:15: ..\..\base/memory/ref_counted.h(131,7) : warning(clang): delete called on 'const media::TypeEnumerator' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] delete static_cast<const T*>(this); ^ ..\..\media\video\capture\win\pin_base_win.cc(40,39) : note(clang): in instantiation of member function 'base::RefCounted<media::TypeEnumerator>::Release' requested here base::RefCounted<TypeEnumerator>::Release(); ^ 1 warning generated. BUG=82385 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284982

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/video/capture/win/pin_base_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Nico
(all media/video/capture/OWNERS are currently away :-/)
6 years, 5 months ago (2014-07-23 01:15:30 UTC) #1
scherkus (not reviewing)
lgtm
6 years, 5 months ago (2014-07-23 01:17:12 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 5 months ago (2014-07-23 04:45:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/410833002/1
6 years, 5 months ago (2014-07-23 04:48:17 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 06:25:12 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 06:40:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/41958)
6 years, 5 months ago (2014-07-23 06:40:44 UTC) #7
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 5 months ago (2014-07-23 17:37:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/410833002/1
6 years, 5 months ago (2014-07-23 17:38:33 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 17:46:36 UTC) #10
Message was sent while issue was closed.
Change committed as 284982

Powered by Google App Engine
This is Rietveld 408576698