Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issue 410813002: [usb_gadget p01] Functions for encoding HID descriptors. (Closed)

Created:
6 years, 5 months ago by Reilly Grant (use Gerrit)
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[usb_gadget p01] Functions for encoding HID descriptors. The hid module defines functions for encoding HID descriptors. These descriptors are much more free-form than USB descriptors so a different approach was taken in this module. BUG=396682 R=rockot@chromium.org,rpaquay@chromium.org,kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285177

Patch Set 1 #

Patch Set 2 : Merged in feedback from the USB descriptors review. #

Patch Set 3 : Fixed copyright text and added specification references. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+432 lines, -5 lines) Patch
A tools/usb_gadget/hid_constants.py View 1 2 1 chunk +140 lines, -0 lines 0 comments Download
A tools/usb_gadget/hid_descriptors.py View 1 2 1 chunk +159 lines, -0 lines 0 comments Download
A tools/usb_gadget/hid_descriptors_test.py View 1 2 1 chunk +125 lines, -0 lines 0 comments Download
M tools/usb_gadget/usb_descriptors.py View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M tools/usb_gadget/usb_descriptors_test.py View 1 2 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Reilly Grant (use Gerrit)
6 years, 5 months ago (2014-07-22 23:10:49 UTC) #1
Reilly Grant (use Gerrit)
6 years, 5 months ago (2014-07-23 00:56:33 UTC) #2
Ken Rockot(use gerrit already)
Just a note while it's in my mind: Please file a meta bug about getting ...
6 years, 5 months ago (2014-07-23 14:45:05 UTC) #3
Ken Rockot(use gerrit already)
lgtm and nice test
6 years, 5 months ago (2014-07-23 15:53:30 UTC) #4
Reilly Grant (use Gerrit)
The CQ bit was checked by reillyg@chromium.org
6 years, 5 months ago (2014-07-23 18:01:29 UTC) #5
Reilly Grant (use Gerrit)
6 years, 5 months ago (2014-07-23 18:01:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reillyg@chromium.org/410813002/60001
6 years, 5 months ago (2014-07-23 18:02:28 UTC) #7
Reilly Grant (use Gerrit)
The CQ bit was unchecked by reillyg@chromium.org
6 years, 5 months ago (2014-07-23 18:34:19 UTC) #8
Reilly Grant (use Gerrit)
The CQ bit was checked by reillyg@chromium.org
6 years, 5 months ago (2014-07-23 23:31:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reillyg@chromium.org/410813002/60001
6 years, 5 months ago (2014-07-23 23:33:39 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 10:50:10 UTC) #11
Message was sent while issue was closed.
Change committed as 285177

Powered by Google App Engine
This is Rietveld 408576698