Corner Passthrough for Accessibility

ash/accessibility_delegate.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_ACCESSIBILITY_DELEGATE_H_
 #define ASH_ACCESSIBILITY_DELEGATE_H_
 
 #include "ash/ash_export.h"
 #include "ash/magnifier/magnifier_constants.h"
 #include "base/time/time.h"
+#include "media/audio/sounds/sounds_manager.h"
 
 namespace ash {
 
 enum AccessibilityNotificationVisibility {
   A11Y_NOTIFICATION_NONE,
   A11Y_NOTIFICATION_SHOW,
 };
 
 enum AccessibilityAlert {
   A11Y_ALERT_NONE,
@@ skipping 64 matching lines @@
   // Gets a saved value of the zoom scale of full screen magnifier. If a value
   // is not saved, return a negative value.
   virtual double GetSavedScreenMagnifierScale() = 0;
 
   // Triggers an accessibility alert to give the user feedback.
   virtual void TriggerAccessibilityAlert(AccessibilityAlert alert) = 0;
 
   // Gets the last accessibility alert that was triggered.
   virtual AccessibilityAlert GetLastAccessibilityAlert() = 0;
 
+  // Plays an earcon. Earcons are brief and distinctive sounds that indicate
+  // when their mapped event has occurred.
+  virtual void PlayEarcon(media::SoundsManager::SoundKey sound_key) = 0;

[James Cook, 2014/07/29 04:27:24]

I would prefer you keep this an "int". I prefer interface definitions to use
plain-old-data types as much as possible.  In particular, interfaces are often
widely #included. Including sounds_manager.h means that every class that uses
this interface recursively includes hash_table.h, string_piece.h, etc.

Let me know if one of your other reviewers disagrees.

[dmazzoni, 2014/07/29 05:47:49]

That's a good reason. How about a comment here specifying the file where the
enums you're supposed to use are defined, then?

[lisayin, 2014/07/30 15:32:51]

Done.

+
   // Initiates play of shutdown sound and returns it's duration.
   virtual base::TimeDelta PlayShutdownSound() const = 0;
 };
 
 }  // namespace ash
 
 #endif  // ASH_ACCESSIBILITY_DELEGATE_H_