ash/accessibility_delegate.h - Issue 410783002: Corner Passthrough for Accessibility

Side by Side Diff: ash/accessibility_delegate.h

Issue 410783002: Corner Passthrough for Accessibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@side-gestures

Patch Set: Fixed some rebase quirks Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | ash/ash_touch_exploration_manager_chromeos.h » ('j') | ash/ash_touch_exploration_manager_chromeos.cc » ('J')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef ASH_ACCESSIBILITY_DELEGATE_H_	5 #ifndef ASH_ACCESSIBILITY_DELEGATE_H_

6 #define ASH_ACCESSIBILITY_DELEGATE_H_	6 #define ASH_ACCESSIBILITY_DELEGATE_H_

7	7

8 #include "ash/ash_export.h"	8 #include "ash/ash_export.h"

9 #include "ash/magnifier/magnifier_constants.h"	9 #include "ash/magnifier/magnifier_constants.h"

10 #include "base/time/time.h"	10 #include "base/time/time.h"

(...skipping 74 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
85 // Gets a saved value of the zoom scale of full screen magnifier. If a value	85 // Gets a saved value of the zoom scale of full screen magnifier. If a value

86 // is not saved, return a negative value.	86 // is not saved, return a negative value.

87 virtual double GetSavedScreenMagnifierScale() = 0;	87 virtual double GetSavedScreenMagnifierScale() = 0;

88	88

89 // Triggers an accessibility alert to give the user feedback.	89 // Triggers an accessibility alert to give the user feedback.

90 virtual void TriggerAccessibilityAlert(AccessibilityAlert alert) = 0;	90 virtual void TriggerAccessibilityAlert(AccessibilityAlert alert) = 0;

91	91

92 // Gets the last accessibility alert that was triggered.	92 // Gets the last accessibility alert that was triggered.

93 virtual AccessibilityAlert GetLastAccessibilityAlert() = 0;	93 virtual AccessibilityAlert GetLastAccessibilityAlert() = 0;

94	94

	95 // Plays an earcon.
	James Cook 2014/07/28 19:10:41 Can you provide a one-sentence description of what Can you provide a one-sentence description of what an "earcon" is in this comment for code readers who may not know? lisayin 2014/07/28 20:31:27 Done. Show quoted text On 2014/07/28 19:10:41, James Cook wrote: > Can you provide a one-sentence description of what an "earcon" is in this > comment for code readers who may not know? Done. lisayin 2014/07/28 20:35:50 Sorry I added it to the wrong file. I will add it Show quoted text On 2014/07/28 20:31:27, lisayin wrote: > On 2014/07/28 19:10:41, James Cook wrote: > > Can you provide a one-sentence description of what an "earcon" is in this > > comment for code readers who may not know? > > Done. Sorry I added it to the wrong file. I will add it to this file as well. dmazzoni 2014/07/28 20:39:05 I'd also be fine with just calling it "sound" here Show quoted text On 2014/07/28 20:35:50, lisayin wrote: > On 2014/07/28 20:31:27, lisayin wrote: > > On 2014/07/28 19:10:41, James Cook wrote: > > > Can you provide a one-sentence description of what an "earcon" is in this > > > comment for code readers who may not know? > > > > Done. > Sorry I added it to the wrong file. I will add it to this file as well. I'd also be fine with just calling it "sound" here. Earcon is a term we use only within screen reader code and documentation. (It's a play on the word "icon")
	96 virtual void PlayEarcon(int sound_key) = 0;

	97

95 // Initiates play of shutdown sound and returns it's duration.	98 // Initiates play of shutdown sound and returns it's duration.

96 virtual base::TimeDelta PlayShutdownSound() const = 0;	99 virtual base::TimeDelta PlayShutdownSound() const = 0;

97 };	100 };

98	101

99 } // namespace ash	102 } // namespace ash

100	103

101 #endif // ASH_ACCESSIBILITY_DELEGATE_H_	104 #endif // ASH_ACCESSIBILITY_DELEGATE_H_

OLD	NEW