Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 410743007: Export content_common dependency from some content targets. (Closed)

Created:
6 years, 5 months ago by tkent
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Export content_common dependency from some content targets. Many Blink headers in public/platform/ include other headers in same directory with relative paths. For now they have |#include "WebFoo.h"|, and we'd like to change it to |#include "public/platform/WebFoo.h"|. This CL is necessary to specify correct include path for them. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285131

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M content/content.gyp View 4 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tkent
Jochen, would you review this please? This is identical to Patch Set 1 of https://codereview.chromium.org/398163008/. ...
6 years, 5 months ago (2014-07-23 04:37:58 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-23 07:01:01 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 5 months ago (2014-07-24 01:05:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/410743007/1
6 years, 5 months ago (2014-07-24 01:09:36 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 02:56:22 UTC) #5
Message was sent while issue was closed.
Change committed as 285131

Powered by Google App Engine
This is Rietveld 408576698