Issue 410733004: Stop passing dummy ParentDetails to NodeRenderingTraversal::parent()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 410733004: Stop passing dummy ParentDetails to NodeRenderingTraversal::parent() (Closed)

Created:
6 years, 5 months ago by Inactive

Modified:
6 years, 5 months ago

Reviewers:
esprehn

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, chromiumbugtracker_adobe.com, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, rwlbuis, rune+blink, sof

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Stop passing dummy ParentDetails to NodeRenderingTraversal::parent() Stop passing dummy ParentDetails to NodeRenderingTraversal::parent(). It handles a null pointer just fine so just make the argument optional and default it to 0. R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178712

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -10 lines)			Patch
	M	Source/core/css/resolver/StyleResolver.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	Source/core/dom/NodeRenderingTraversal.h	View		2 chunks	+1 line, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/410733004/1

6 years, 5 months ago (2014-07-22 22:34:34 UTC) #3

Message was sent while issue was closed.

Change committed as 178712

Expand Messages | Collapse Messages