Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 410733003: Rebaseline/update the intl tests with ICU 52 (Closed)

Created:
6 years, 5 months ago by jungshik at Google
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Rebaseline/update the intl tests with ICU 52 Update the following 4 intl tests after ICU 52 roll. date-format/parse-MMMdy.js date-format/parse-mdyhms.js number-format/parse-decimal.js number-format/parse-percent.js BUG=v8:3454 TEST=intl/* tests pass. LOG=Y R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22544

Patch Set 1 #

Patch Set 2 : update status file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M test/intl/date-format/parse-MMMdy.js View 1 chunk +5 lines, -2 lines 0 comments Download
M test/intl/date-format/parse-mdyhms.js View 1 chunk +1 line, -1 line 0 comments Download
M test/intl/intl.status View 1 1 chunk +0 lines, -6 lines 0 comments Download
M test/intl/number-format/parse-decimal.js View 1 chunk +3 lines, -1 line 0 comments Download
M test/intl/number-format/parse-percent.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
jungshik at Google
Asking for review.
6 years, 5 months ago (2014-07-22 19:27:48 UTC) #1
jochen (gone - plz use gerrit)
On 2014/07/22 19:27:48, Jungshik Shin wrote: > Asking for review. Can you also remove the ...
6 years, 5 months ago (2014-07-22 19:31:09 UTC) #2
jungshik at Google
On 2014/07/22 19:31:09, jochen wrote: > On 2014/07/22 19:27:48, Jungshik Shin wrote: > > Asking ...
6 years, 5 months ago (2014-07-22 21:01:35 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-23 07:05:57 UTC) #4
jungshik at Google
The CQ bit was checked by jshin@chromium.org
6 years, 5 months ago (2014-07-23 07:58:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/jshin@chromium.org/410733003/20001
6 years, 5 months ago (2014-07-23 07:59:16 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 07:59:16 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-23 07:59:17 UTC) #8
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-07-23 09:01:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r22544 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698