Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 410703003: Always use the legacy GeolocationPermission APIs (Closed)

Created:
6 years, 5 months ago by michaelbai
Modified:
6 years, 5 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Always use the legacy GeolocationPermission APIs BUG=396184 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285043

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
michaelbai
PTAL
6 years, 5 months ago (2014-07-22 19:10:38 UTC) #1
Primiano Tucci (use gerrit)
lgtm https://codereview.chromium.org/410703003/diff/1/android_webview/java/src/org/chromium/android_webview/AwContents.java File android_webview/java/src/org/chromium/android_webview/AwContents.java (right): https://codereview.chromium.org/410703003/diff/1/android_webview/java/src/org/chromium/android_webview/AwContents.java#newcode2401 android_webview/java/src/org/chromium/android_webview/AwContents.java:2401: // Always return true since we are not ...
6 years, 5 months ago (2014-07-22 20:32:08 UTC) #2
benm (inactive)
lgtm
6 years, 5 months ago (2014-07-22 20:59:53 UTC) #3
mkosiba (inactive)
lgtm
6 years, 5 months ago (2014-07-23 14:43:41 UTC) #4
michaelbai
The CQ bit was checked by michaelbai@chromium.org
6 years, 5 months ago (2014-07-23 17:47:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/410703003/20001
6 years, 5 months ago (2014-07-23 17:48:41 UTC) #6
michaelbai
All android bots passed
6 years, 5 months ago (2014-07-23 21:14:22 UTC) #7
michaelbai
The CQ bit was unchecked by michaelbai@chromium.org
6 years, 5 months ago (2014-07-23 21:14:33 UTC) #8
michaelbai
The CQ bit was checked by michaelbai@chromium.org
6 years, 5 months ago (2014-07-23 21:14:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/410703003/20001
6 years, 5 months ago (2014-07-23 21:15:31 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 21:18:41 UTC) #11
Message was sent while issue was closed.
Change committed as 285043

Powered by Google App Engine
This is Rietveld 408576698