Issue 410683008: Remove kAppsGalleryInstallAutoConfirmForTests switch

Issue 410683008: Remove kAppsGalleryInstallAutoConfirmForTests switch (Closed)

Created:
6 years, 5 months ago by Devlin

Modified:
6 years, 5 months ago

Reviewers:
asargent_no_longer_on_chrome, Peter Kasting, Andrew T Wilson (Slow)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Remove kAppsGalleryInstallAutoConfirmForTests switch This is a potentially dangerous switch, and having it as a commandline offers nothing better than simply having a static global boolean. TBR=pkasting@chromium.org (infobars) TBR=atwilson@chromium.org (policy) TBRs for purely mechanical changes. BUG=357774 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285200

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+93 lines, -110 lines)			Patch
M	chrome/browser/extensions/api/management/management_api_browsertest.cc	View	4 chunks	+4 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_prompt.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_prompt.cc	View	2 chunks	+23 lines, -24 lines	0 comments	Download
M	chrome/browser/extensions/extension_service_unittest.cc	View	3 chunks	+6 lines, -9 lines	0 comments	Download
M	chrome/browser/extensions/unpacked_installer.cc	View	3 chunks	+12 lines, -16 lines	0 comments	Download
M	chrome/browser/extensions/webstore_inline_installer_browsertest.cc	View	4 chunks	+4 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/webstore_installer_test.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/webstore_startup_installer_browsertest.cc	View	11 chunks	+21 lines, -20 lines	0 comments	Download
M	chrome/browser/infobars/infobars_browsertest.cc	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/policy/policy_browsertest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+0 lines, -13 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/410683008/1

6 years, 5 months ago (2014-07-23 23:00:10 UTC) #4

Message was sent while issue was closed.

Change committed as 285200