Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1371)

Issue 410683007: Suppress MissingApplicationIcon Android lint warning. (Closed)

Created:
6 years, 5 months ago by newt (away)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Suppress MissingApplicationIcon Android lint warning. We have lots of test APKs that don't need application icons. And I think we'd notice if Chrome itself was missing an icon even without this warning ;) BUG=393235 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284992

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/android/lint/suppressions.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
newt (away)
PTAL
6 years, 5 months ago (2014-07-23 16:25:17 UTC) #1
aurimas (slooooooooow)
lgtm
6 years, 5 months ago (2014-07-23 16:27:18 UTC) #2
newt (away)
The CQ bit was checked by newt@chromium.org
6 years, 5 months ago (2014-07-23 17:38:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/410683007/1
6 years, 5 months ago (2014-07-23 17:40:17 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 17:57:10 UTC) #5
Message was sent while issue was closed.
Change committed as 284992

Powered by Google App Engine
This is Rietveld 408576698