Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4243)

Unified Diff: chrome/chrome_browser.gypi

Issue 410673002: [Suggestions] Moving suggestions code to a new component (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: gn fix Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_browser.gypi
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index 3c2128b0566f779362649887f8fbd5a523c37c29..7b5404e46506971791cfde2baad0830516d471a9 100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -1144,17 +1144,10 @@
'browser/search/most_visited_iframe_source.h',
'browser/search/search.cc',
'browser/search/search.h',
- 'browser/search/suggestions/blacklist_store.cc',
- 'browser/search/suggestions/blacklist_store.h',
- 'browser/search/suggestions/image_manager.h',
- 'browser/search/suggestions/suggestions_service.cc',
- 'browser/search/suggestions/suggestions_service.h',
'browser/search/suggestions/suggestions_service_factory.cc',
'browser/search/suggestions/suggestions_service_factory.h',
'browser/search/suggestions/suggestions_source.cc',
'browser/search/suggestions/suggestions_source.h',
- 'browser/search/suggestions/suggestions_store.cc',
- 'browser/search/suggestions/suggestions_store.h',
'browser/search/suggestions/thumbnail_manager.cc',
'browser/search/suggestions/thumbnail_manager.h',
'browser/search_engines/chrome_template_url_service_client.cc',
@@ -2849,7 +2842,6 @@
'common_net',
'in_memory_url_index_cache_proto',
'probe_message_proto',
- 'suggestions_proto',
'../components/components.gyp:autocomplete',
'../components/components.gyp:autofill_core_browser',
'../components/components.gyp:bookmarks_browser',
@@ -2882,6 +2874,7 @@
'../components/components.gyp:search',
'../components/components.gyp:search_engines',
'../components/components.gyp:search_provider_logos',
+ '../components/components.gyp:suggestions',
'../components/components.gyp:signin_core_browser',
'../components/components.gyp:startup_metric_utils',
'../components/components.gyp:sync_driver',
@@ -3441,18 +3434,6 @@
'includes': [ '../build/protoc.gypi', ],
},
{
- # Protobuf compiler / generator for the suggestions service proto.
- # GN version: //chrome/browser/search/suggestions/proto
- 'target_name': 'suggestions_proto',
- 'type': 'static_library',
- 'sources': [ 'browser/search/suggestions/proto/suggestions.proto', ],
- 'variables': {
- 'proto_in_dir': 'browser/search/suggestions/proto',
- 'proto_out_dir': 'chrome/browser/search/suggestions/proto',
- },
- 'includes': [ '../build/protoc.gypi', ],
- },
- {
# Protobuf compiler / generator for Probe Message.
# GN version: //chrome/browser/net:probe_message_proto
'target_name': 'probe_message_proto',

Powered by Google App Engine
This is Rietveld 408576698