components/suggestions/DEPS - Issue 410673002: [Suggestions] Moving suggestions code to a new component

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/suggestions/DEPS

Issue 410673002: [Suggestions] Moving suggestions code to a new component (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: clean Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 include_rules = [

	2 "+content/public",
	blundell 2014/07/22 15:55:19 If this component is intended to be shared by iOS If this component is intended to be shared by iOS (as it looks like from components.gyp), then it shouldn't use the content API. What is it using the content API for? If it's just BrowserThread, it's fairly trivial to refactor. Mathieu 2014/07/22 16:56:31 Yes, it's for BrowserThread. Does iOS have the con Show quoted text On 2014/07/22 15:55:19, blundell wrote: > If this component is intended to be shared by iOS (as it looks like from > components.gyp), then it shouldn't use the content API. What is it using the > content API for? If it's just BrowserThread, it's fairly trivial to refactor. Yes, it's for BrowserThread. Does iOS have the concept of threads? Could we remove dependence on content/ in a follow-up CL? Mathieu 2014/07/22 17:12:42 If not possible, I can put this CL on hold and try Show quoted text On 2014/07/22 16:56:31, Mathieu Perreault wrote: > On 2014/07/22 15:55:19, blundell wrote: > > If this component is intended to be shared by iOS (as it looks like from > > components.gyp), then it shouldn't use the content API. What is it using the > > content API for? If it's just BrowserThread, it's fairly trivial to refactor. > > Yes, it's for BrowserThread. Does iOS have the concept of threads? Could we > remove dependence on content/ in a follow-up CL? If not possible, I can put this CL on hold and try to remove dependence on content/ in my code. Not sure how to remove the support for threads though.
	3 "+components/keyed_service",

	4 "+components/pref_registry",

	5 "+components/variations",

	6 "+net",

	7 "+ui",

	8 "+url",

	9 ]

OLD	NEW

« no previous file with comments | « components/suggestions/BUILD.gn ('k') | components/suggestions/OWNERS » ('j') | no next file with comments »